P
Gonzalo Tejada• 130
@vgt3j4d4
Posted
- Does the solution include semantic HTML?
it is using
<main>and<article>. I'm not really sure if<article>applies but I do believe<header>could have been used. I found this in Frontend Mentor Discord which might help you. This might be helpful too HTML5 alternatives to div. - Is it accessible, and what improvements could be made? Use more semantic html
- Does the layout look good on a range of screen sizes? I think it can be improved. I have access to the figma files I was able to get the precise dimensions which I'm pretty close to match my solution here
- Is the code well-structured, readable, and reusable? yeah
- Does the solution differ considerably from the design? yes, I believe in the mobile version the solution is not really matching the design
0
Mateus Lima• 230
@mts-ml
Posted
Hey, @vgt3j4d4
Thanks for the feedback!
1
P
Gonzalo Tejada• 130
@vgt3j4d4
Posted
@mts-ml after working on some more challenges I'm starting to think that <article> is ok. Just wanted to point out that :)
0
Mateus Lima• 230
@mts-ml
Posted
Hey @vgt3j4d4 !
What I've found reading is that article should be used as independent from the rest of the tags, in this challenge, I could've used just a <main> tag and some <div>, without article and aside, since it's a pretty small project.
1
