Product preview card component

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi MD5 Dalton, good question, I'm also curious how long it takes to complete a challenge like this; since I've already done this one, I might find a similar one to do and time myself.

  Great work here overall, and by the way, if you're wondering why the font family looks different in your screenshot compared to the design, it's because you're using the optical view version of this font. To make the screenshot look like the design's, you'll just need to copy the link again and uncheck the optical view box. As for other feedback, I think the only thing I would change is changing the div tags into inline text elements if they aren't doing anything particular (e.g., being used for flexbox), or just wrap the text in an inline text element, which would be better for semantic HTML than using a div for just text.

  If I ever time myself, will be sure to let you know! 🙂

  Marked as helpful

  1

  ---

  

  Md5 dalton•1,430

  @md5daltonPosted about 2 years ago

  I appreciate the hint @elaineleung, I've had my head spinning trying to figure out what the issue was with the screenshot😓.

  I'll also swap those divs for the spans.

  I'm looking forward to hear how you'd do on that.👌

  1