Product preview card component

Community feedback

• 

  Iseoluwa Osho•180

  @theCephasPosted over 2 years ago

  Hey @BunmiFash

  Great work on the project there. However, there are certain things that ought to be addressed in this project. You can also check out my profile to view my code, compare to yours to see how it can help(not that mine's perfect though, but better).

  Also, I'll address just few things here;

  • For your .attribution, remove the margin top. It's either your remove it or use px because it is making your mobile view image run to the top of the image, hence, it could not be seen well. • You used lots of varying max-height(s), why not just put min-height: 100vh; just once for your body. It could prolly not work because of how you structured your webpage. • In projets like these, it's best to make the desktop view first, then mobile view can come afterwards, hence using max-width: 400px; depending on your preference. • For the two different images, you can also read on the <picture> element. It makes related works like that very easy.

  Great Work on your Project, Bunmi. Please mark this helpful if you do find it helpful. Bless.

  Marked as helpful

  0

  ---

  

  Blessing Oluwabunmi Fashina•10

  @BunmiFashPosted over 2 years ago

  @theCephas Thank you so much for this feedback. I'll work on those details.

  0