Design comparison
Solution retrospective
can you please provide feedback and some tips for me?
Community feedback
- @MJEstacioPosted almost 2 years ago
Hey there @gautam_hub, very good job on your project, I saw your project, but you need to change some of the following:
Footer Change your footer to
position: absolute; bottom:0; left: 0; width:100vw; text-align:center;
so that your footer is below your website and it will be on the center.Fonts You forgot to change the color for some fonts. you can add classes for each price so you can modify it based on their classes.
Well everything looks good, and good job! Happy Coding! ✌
0 - @Ambe-Mbong-NwiPosted almost 2 years ago
Hello, great job there. To centralise your page, use flexbox or grid layout to center elements. You can read more about centering in CSS here: Using flexbox:
body { min-height: 100vh; display: flex; justify-content: center; align-items: center; }
Using grid:
body { min-height: 100vh; display: grid; place-content: center; }
0 - @KonstantinchristPosted almost 2 years ago
Hi @gautam-hub, I really like your project. I just think that you forgot to make your parents borders round and also I don't understand why your 'add to cart' button has a margin-left of 10 px.
example for the border-radius:
.parent{ border-radius: 1rem; overflow: hidden; /* prevent the img from overflowing*/ }
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord