Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hi @Roveri91 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉
Here are some suggestions you might consider:
- Try to use semantic tags in your code. Click here for more information.:
With semantic tags:
<body>
<main class="card">
. . .
</main>
<footer class="attribution">
. . .
</footer>
<body>
- You can use a <picture> tag when you need to change an image in different viewports. Using this tag will prevent the browser from loading both images, saving bandwidth and preventing you from utilizing a media query to modify the image.
Example:
<picture>
<source media="(max-width: 550px)" srcset="./images/image-product-mobile.jpg">
<img src="./images/image-product-desktop.jpg" alt="your_alt_text">
</picture>
-
Instead of using pixels in font size, use relative units of measure like
remorem. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference. -
The cart icon is for decoration purposes only, so it can be hidden from screen-readers by adding
aria-hidden="true"and leaving its alt attribute empty:
<img src="./images/icon-cart.svg" alt aria-hidden="true">
- You could use the <del> tag to display the old price:
<del>$169.99</del>
I hope those tips will help you.
Good job, and happy coding!
0
