Design comparison
SolutionDesign
Solution retrospective
Any feedback will be appreciated
Community feedback
- @fmanimashaunPosted almost 2 years ago
Hi,
Quite an impressive implementation. I noticed you used a lot of divs. Using semantic markups instead of the generic div tag would be nice. It will help with accessibility and make your code more readable.
Also, I think your vertical spaces between elements might need a bit of consideration as your final layout looks a bit bigger than the given layout.
Overall, I like your submission! Keep it up! cheers
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord