Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card Component

Bunchydo 70

@Bunchydo

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What challenges did you encounter, and how did you overcome them?

Trying to get it responsive proved very difficult. It is not perfect but it is still a start.

What specific areas of your project would you like help with?

I would really like to know more efficient ways in knowing how to make websites responsive. I started with a desktop approach first. Should i have started with mobile design first. What about the code can I change to improve

Community feedback

@KapteynUniverse

Posted

Hey @Bunchydo,

What i try to do recently is look for both mobile and desktop design, so i can decide how to approach like how to start and what will change then start with mobile. When you write the HTML code, most of the times it is mobile layout just without styles

Use a modern css reset for every project. It will make your life a little bit easier.

Headings (h1-h6) are not for the sizes. <h1> headings should be used for main headings, followed by <h2> headings, then the less important <h3>, and so on. There is a visual for better understanding here, under nesting

Wrap the content in a main landmark If will be times to use other landmarks too.

Looks like you know flexbox, but used absolute positioning for centering. For future challenges you can use this or grid for centering.

body {
display: flex;
justify-content: center;
align-items: center;
min-height: 100vh;
}

Also instead of pixels use em/rem units for better responsibility

Kevin Powell made a video about this challenge. I recommend you to check it. He also have a couple for em/rem units.

Marked as helpful

0

Bunchydo 70

@Bunchydo

Posted

Hi KapteynUniverse,

Thank you very much for this reply. It clears up a lot of things.👍

0
Adriano 36,730

@AdrianoEscarabote

Posted

Hello Bunchydo, how are you? I was really pleased with your project, but I’d like to offer some advice that might help:

Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

See the example below:

<picture>
  <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
  <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>

The rest is spot on.

Hope it’s helpful to you. 👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord