Product preview card component

Community feedback

• 

  Oscar Bocanegra•235

  @obocanegra-devPosted over 1 year ago

  Hello kokenydaniel! 👋

  Congratulations on your incredible work in the Frontend Mentor challenge! 🎉 You've done a great job, and I would like to offer you some suggestions to further improve your project:

  I noticed that the card container appears large on small screens because the width is fixed. I recommend adding a max-width property to the container to make it better fit on smaller devices. This will help your design look more balanced and responsive.

  I suggest adding a breakpoint earlier, with a higher number of pixels, as 375px is quite low. This way, you can ensure that your design looks good on a wider range of screens and devices.

  I recommend using semantic elements in your HTML instead of relying too much on generic divs. This will help improve the structure and accessibility of your code by providing clear semantic meaning to each section of your page.

  For your next project, I strongly recommend adopting the "mobile first" approach. Starting with designing and developing for mobile devices will allow you to build a solid foundation and ensure an optimal user experience on all devices.

  Additionally, consider taking advantage of the current design to add interesting interactions with the hover effect on the button. This can add an interactive and appealing touch to your project.

  Overall, I want to congratulate you again on your work. You've truly achieved something great! These suggestions are meant to help you take your project to the next level.

  Keep up the great work and don't hesitate to explore more challenges on Frontend Mentor to continue improving your skills! 💪

  Wishing you much success in your future projects! 🚀✨

  Best regards, Oscar

  Marked as helpful

  0

  ---

  

  kokenydaniel•50

  @kokenydanielPosted over 1 year ago

  @obocanegra-dev

  Hi Oscar!

  Thank you very much for your feedback! I will use what you suggested in this and other projects as well!

  Should I use section and article? Or did you not think of these?

  Thanks again!

  Daniel

  0

  

  Oscar Bocanegra•235

  @obocanegra-devPosted over 1 year ago

  @kokenydaniel

  You're welcome! Yes, I would definitely use a <section> element instead of the <div class="details">. That will help improve the semantics and structure of your code! If you have any other questions or need further assistance, feel free to ask. Keep up the great work with your project! 💪🚀

  Marked as helpful

  0