Responsive Product Page using Flex Box

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • It is best practice to use, classes for your naming convention as classes are reusable, making them ideal for CSS styling. IDs on the other hand, are not reusable and are mainly used for JavaScript.

  • Do not capitalize the "perfume" in HTML as it is not accessible friendly. Instead use CSS to style it.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0
• 

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  HEY UMER!

  I would like to give some suggestions on how your code can be improved:

  To prevent your image from blurring, on the desktop design, you should use the code object-fit: cover.

  I see you also used the wrong font for the discounted price, just something to inform you of.

  You should also add some space between your description and price.

  To prevent the accessibiliy issues you currently have, you will not only need to give your image an alt text, you will also need to replace the div in <div id="outer-box"> with a more semantic element like main

  HOPE I COULD BE OF HELP :)

  HAPPY CODING!

  Marked as helpful

  0
• 

  Lisakhanya Mbuwa•10

  @Lisakhanya444Posted almost 2 years ago

  To make it simple: Use a class when you need multiple copies of the same object (instances) that you want to add functions (methods) or values (properties) to. The advantage is that all those objects can share the same functions but still have different values.

  0