Product preview card component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0

  ---

  

  Jose Elias Morales•70

  @JoseEliasMoralesPosted almost 2 years ago

  @vcarames Thank you so much for the feedback! All help is well received. I'm applying the advice you've given me. The only problem I have now is that of the alt tag. I'm using the source of information you gave me, and I think in this case it's best to leave the attribute alt empty, because next to the image in the title refers to what's in the image.

  Am I getting it right?

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @JoseEliasMorales

  I am glad that I was able to help out!

  For this challenge the image is the product you’re selling. So it’s vital that it has an alt tag description. Remember, not every user has perfect eyesight. So if they use assistive technology, the alt tag will describe how the product looks like; what its shape is, material, etc…

  Keep it up!

  0