Desktop-first-solution using SCSS

Community feedback

• 

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  HEY PHUONG, I HAVE SOME SUGGESTIONS ON HOW YOUR CODE COULD BE IMPROVED :)

  Instead of using the figure element, it would be better to use the picture element, as it will enable to show different images at different widths, HERE IS SOME INFORMATION ON THAT.

  Instead of putting a div inside the button element, it would be more advisable to put an image inside it then adding the text, or usING a `:: before`` pseudo-element.

  It is also advisable to not use so many media queries, only when you want to change the appearance of certain things at different viewports, on the .overview, to change it on a 1440px screen, you would have to declare it as a display: flex and change the direction to to flex-direction: row; and for the mobile design, the direction would have to be flex-direction: column;.

  IF YOU FOUND THIS HELP ANYWAY HELPFUL, DON'T HESITATE TO MARK IT AS HELPFUL :)

  *HAPPY CODING!

  Marked as helpful

  0