@Hassiai
Posted
Replace<div class="card">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .card on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units Click here
Give .card the card a max-width value, instead giving the body a width value that is equal to screen-size that was specified in the styleguide.md
the desktop image is not visible because you forgot to add "./" in the beginning of the url value. url('./images/image-product-desktop.jpg') instead of url('images/image-product-desktop.jpg')
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful