Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

FlexBox and media queries

@Fanou59

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


A new version of this challenge :)

Give me feedback please !

Community feedback

@MelvinAguilar

Posted

Hi @Fanou59 👋, good job completing this challenge! 🎉

I like this solution for the challenge. I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="container"> to improve the accessibility of the website.
  • In this challenge, you should not use the background property to set the image because this image has semantic meaning. Use the CSS background property if the image is not part of the content.
  • Setting a defined height (height: 450px;) for the component is not recommended. The content should define the component height, otherwise, it will not be allowed to extend beyond your specifications. Alternatively, you can use min-height.
  • Setting element width with percentages or VW will cause your component to behave weirdly on mobile devices and high-resolution desktops. You can set the max-width at 600px and remove the width: 40vw;
  • The <div> tag defines a division or section on a website. It is used to style a container with CSS, set special alignment, or position content. It might be more efficient to use the <h1> tag; the <h1> element is the main heading on a webpage, also, there should only be one <h1> tag per page.
<h1 class="container-title">Gabrielle Essence Eau De Parfum</h1>

Above all, the project is done well👏. I hope those tips will help you! 👍

Good job, and happy coding! 😁

Marked as helpful

0

@Fanou59

Posted

@MelvinAguilar Thank you so much for your feedback :) It'll help me a lot !

Regards, Steph

1

@KevinEscobarDeveloper

Posted

Your page isn't responsive brah, yo have to check that.

0

@Fanou59

Posted

@KevinEscobarDeveloper

It isn't responsive but adaptative on mobile. It was the purpose of this challenge no ? So I've adapted the desktop version with media queries for the mobile version.

0

@KevinEscobarDeveloper

Posted

@Fanou59 you're right good job

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord