Design comparison
Community feedback
- @catherineisonlinePosted almost 2 years ago
HI! Your solution looks nice though there are a couple of things you can improve which I hope will be helpful! π
Heading levels should only increase by one. This means that when you have several headings they should downgrade by one. So, you start with h1, then h2, and then h3 and not h5 right away, for example. If you are repeating the same headings, it's okay. That doesn't mean every next heading needs to be different, beside the h1 (it can only be used once).
Also, make sure to wrap the entire code in the main tag instead of using the div, the one where the class is βmainβ. It will help to remove report issues and improve accessibility as well. If you are using, for example, header or footer tags, you can place them outside the main tag.
Also, I recommend setting the max-width for the container so it doesn't;t stretch too much on bigger screens. When you set for example max-width: 30rem; the container will never become larger than 30rem. If you set only % it will keep stretching as the width grows. The button looks not so pleasing after 1440px
Marked as helpful0@AshBorn14Posted almost 2 years ago@catherineisonline Thank you very much for you feedback.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord