Product Preview Card Component using HTML and CSS
Design comparison
Solution retrospective
Will tweak it later on, Feeback on this will be highly appreciated
Community feedback
- @catherineisonlinePosted almost 2 years ago
Nice! ๐๐ป
I would also add some transitions for active states (when colors change on hover). It creates more interactivity and makes the project looks cooler. Active states can be done on buttons, links, titles which act like links or anything else, you choose.
You can read more about it here, in case you havenโt done much of it:โจhttps://www.w3schools.com/css/css3_transitions.asp
IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL ๐คฉ
Marked as helpful0 - @VCaramesPosted almost 2 years ago
Hey there! ๐ Here are some suggestions to help improve your code:
- Since the images in this component add value and serve a purpose (displaying the product), it is best to use the
Picture
element and not thebackground-image
property, as it will to use different images during different breakpoints.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:๐
https://www.w3schools.com/html/html_images_picture.asp
- The only heading in this component, is the name of the perfume; โGabrielle Essence Eau De Parfumโ . The rest of the text should be wrapped in a
paragraph
element.
- Currently, the old price (169.99) ๐ท is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
del
element and inside it you will add aspan
element with ansr-only class
that will state something like โThe previous price wasโฆโ and use CSS to make it only visible to screen readers.
More Info:๐
- Your "button" was created with the incorrect element. It should be created using the
button
element. So that when the user clicks on the button (with the help of JS) it should add the product to the cart.
More Info:๐
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!๐๐
Marked as helpful0 - Since the images in this component add value and serve a purpose (displaying the product), it is best to use the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord