Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Flex😐

bananasplitβ€’ 30

@1bananasplit

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have some feedback for you if you want to improve your code.

HTML πŸ“„:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
  • You could use the <del> tag to indicate the price that was before the discount. Additionally, you can use a sr-only class to describe the discount. This will help screen reader users to understand that the price was discounted.

    Example:

    <del><span class="sr-only">Old price: </span>$169.99</del>
    
  • You can use the <picture> tag when you have different versions of the same image πŸ–Ό. Using the <picture> tag will help you to load the correct image for the user's device saving bandwidth and improving performance. You can read more about this here πŸ“˜.

    Example:

    <picture>
        <source media="(max-width: 460px)" srcset="./images/image-product-mobile.jpg">
        <img src="./images/image-product-desktop.jpg" alt="{your alt text goes here}">
    </picture>
    

CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding!

Marked as helpful

0

bananasplitβ€’ 30

@1bananasplit

Posted

@MelvinAguilar okay I thanks for all of that,🍌πŸ₯²πŸ‘πŸ˜Άβ€πŸŒ«οΈ

1
Fabio Santosβ€’ 150

@fbs4ntos

Posted

Use the 'main' tag when inves from a div to the main item. Of a look : https://www.w3schools.com/tags/tag_main.asp

Try using class in 'p' tag, only in dire need. Because there are other ways to select the element. https://www.w3schools.com/cssref/css_selectors.php

0

bananasplitβ€’ 30

@1bananasplit

Posted

@fbs4ntos Yes I know , thanks you, I do this at 1Am and I was very tired. πŸ˜…πŸ‘πŸŒβ™₯️

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord