Design comparison
Solution retrospective
I have tried my very first responive wep page using reference in google. please sport the errors , recommed the code that make more effency and intrative
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @harishfuego33!
You did a very good job there!
Since you already got help, I have just one suggestion for improvement:
- Since the button add to cart is a clickable element, it's nice to add
cursor: pointer
to it. It gives the user a visual indication that the element is clickable.
I hope it helps!
Other than those details, you did a great job!
Marked as helpful0 - Since the button add to cart is a clickable element, it's nice to add
- @MelvinAguilarPosted 11 months ago
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π·οΈ:
-
Wrap the page's whole main content in the
<main>
tag. -
The
<h1>
is the most important heading on the page, In this challenge the perfumer's name can be considered like the title of the page, so it should be the<h1>
CSS π¨:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource π.
- Avoid using
position: absolute
to center an element as it may result in overflow on some screen sizes. Instead, utilize the flexbox or grid layout for centering. Get more insights on centering in CSS here here π.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord