product-preview-card-component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<section class="card">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .card on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .card on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .card on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  in the mobile design give .card a max-width value for a responsive content instead of width: auto. e,g: max-width: 400.

  In the media query, increase the max-width value of .card max-width: 600px. Give .card-image--desktop display: block and a width of 50% and give card-article a width of 50% and increase the padding value for all the sides padding: 2em. there is no need for margin-bottom value and justify-content in .card_article.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  1

  ---

  

  rymxoxo•60

  @rymxoxoPosted almost 2 years ago

  @Hassiai Thank you so much for your time and advice .

  I have uploaded the new version of my code , now i'm facing the hover problem and the image does not want to fit

  0
• 

  Arun•90

  @ninjabroPosted almost 2 years ago

  i might want you to work on the layout first

  size for desktop is too big, reduce the size and you should be good to go!

  i used grid for layout and flex for inside div containers

  you could improve these below listed

  center the card container in body , paddings around the perfume card, button font size, height of button.

  hope this might help you

  0

  ---

  

  rymxoxo•60

  @rymxoxoPosted almost 2 years ago

  @ninjabro Thank you so much for your time and advice .

  I have uploaded the new version of my code , now i'm facing the hover problem and the image does not want to fit

  0