Product preview card component - Solution

Community feedback

• 

  Adriano•42,780

  @AdrianoEscarabotePosted 4 months ago

  Hi Jerald Bianan, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  The rest is excellent.

  I hope you find it useful. 👍

  Marked as helpful

  0

  ---

  

  P

  Jerald Bianan•100

  @jeraldbiananPosted 4 months ago

  @AdrianoEscarabote Thank you for this wonderful suggestion.

  1
• 

  Dadv-a11y•420

  @Dadv-a11yPosted 4 months ago

  the layout is not well display on different range of screen on my laptop the layout is display as on a mobile

  Marked as helpful

  0

  ---

  

  P

  Jerald Bianan•100

  @jeraldbiananPosted 4 months ago

  @Dadv-a11y Ahh I see, I used mobile first approach, and in the figma design there is no design for tablet(768px), only for mobile and desktop which is 1440px. Thank you for this, appreciate it.

  I think I will have to consider the tablet view, once the tablet view is reached the desktop design will be viewed, because it looks like your laptop resolution is below 1440px.

  0

  

  Dadv-a11y•420

  @Dadv-a11yPosted 4 months ago

  @jeraldbianan i am glad to be helpful

  0