Skip to content
Submitted 4 months ago

Product Preview Card Component - Responsive - Vite, Svelte

Jim Barnett•260
@jamesbarnett
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I initially did this challenge in just CSS and HTML. I was happy with how relatively pain free it was to convert it to Svelte.

I think the styling would have been more succinct if I had been writing this as Svelte components from the start (fewer class names).

What challenges did you encounter, and how did you overcome them?

Just learning the path conventions for components and assets. I overcame them by reading the error messages and correcting them. Svelte error messages were great in this area.

What specific areas of your project would you like help with?

Really just wanted to get a feel for Svelte, but am interested in hearing feedback in regards to accessibility (did I miss opportunities to use any aria- features?) and responsiveness.

Community feedback

  • Dylan de Bruijn•3,230
    @DylandeBruijnPosted 4 months ago

    @jamesbarnett

    Hiya! 👋

    Congratulations on your solution, it looks very close to the design! I haven't use Svelte before so I can't give specific feedback on that, but I do have experience with React, Angular and Vue.

    Things I like about your solution 🎉

    • Use of semantic HTML elements
    • Clear descriptive CSS classes
    • Use of CSS custom properties
    • Use of Svelte
    • Use of Vite

    Things you could improve ✍️

    • The cart icon is not displaying in the button, maybe the URL is invalid?

    • I suggest you use a p for your product category

    I hope you find my feedback helpful! 🌟

    Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

    Happy coding! 😎

    Marked as helpful
    1
    Jim Barnett•260
    @jamesbarnettPosted 4 months ago

    @DylandeBruijn Thank you so much for the catch on the icon! I also took your advice on the p tag.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord