@DylandeBruijn
Posted
@Jackson-zablon15
Hiya! ๐
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution ๐
- Use of semantic HTML elements
- Clear descriptive CSS classes
- Use of CSS custom properties
Things you could improve โ๏ธ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
Be careful with setting a fixed
width
andheight
on your elements. If the content in these elements grows beyond these restrictions youโll run into overflow issues. Keeping theheight
atauto
- whichblock
elements are by default - will be fine in most cases. -
Try styling your elements using classes instead of IDโs. Most of the time they are the better choice. IDโs are mostly used to select elements using JavaScript, navigation on the page itself and to style unique elements.
-
You donโt have to wrap your image in a separate
div
, itโs possible to style it directly to achieve the same result. -
Try using the
picture
element and making your solution more responsive.
I hope you find my feedback helpful! ๐
Let me know if you have more questions and I'll do my best to answer them. ๐โโ๏ธ
Happy coding! ๐
Marked as helpful
@Jackson-zablon15
Posted
@DylandeBruijn Thank you so much for the help. I'm going to use your tips and i know i will learn alot from them.