Design comparison
Solution retrospective
I think the only thing I'm not very confident about is the responsiveness of the site. I used the basics of semantic HTML and CSS with flexbox.
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML ๐:
-
The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.If you want to learn more about the
alt
attribute, you can read this article. ๐.
-
Add
aria-hidden="true"
andfocusable="false"
to the SVG element to hide it from technologies such as screen readers.The main reason for hiding an SVG from screen readers is that SVGs can be used for decorative elements and may not provide any meaningful information to users of assistive technology. Hiding them from screen readers can prevent confusion and reduce the amount of unnecessary information that is read to users.
CSS ๐จ:
- The
min-width: 100vw
property in thebody
tag is not necessary. This will create a horizontal scrollbar on some devices.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord