Product preview card

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 2 years ago

  Nice work Pradeep Saini. Your solution looks good. You can polish it up a bit to make it about the same size on desktop, It looks a bit shorter. Interesting also on the use of inline-size: 100vw; , something that i wasn't aware of. Nicely done with the picture element, although i would encourage the source to be self closing . On alt values , i would also recommend values that are descriptive - that can be of great help to assistive technology users. Values such as alt="card icon" are of no help to people who rely on assistive technology. If the image is just decorative, the alt="" is sufficient. .

  Marked as helpful

  0

  ---

  

  Pradeep Saini•990

  @pradeeps4iniPosted over 2 years ago

  @ChamuMutezva Thanks for reading the code.

  You're right, i need to work on the desktop mode. It is shorter than the solution.

  I wrote "card icon" only for the sake of writing. I'll have to take care to write descriptive alts from next time.

  If you want to learn more about inline-size and similar properties. Read about the internationalization css. It is very helpful to write flexible css code which can support various writing modes..

  0