@mkboris
Posted
Hi Supa-Thobile2 great job, some suggestions
- Responsive images are handled using html elements and techniques such as the
picture
element. Using CSS to hide and show images (when given images to display according to screen sizes) is not part of the best practices - Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
- Media queries should be defined in rem or em not px.
- All content should be wrapped within landmarks. Wrap a
footer
tag around the attribution. - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
Hope this helps
Marked as helpful
@Supa-Thobile2
Posted
@mkboris Thank you! I am in awe of the masterclass in frontend wisdom you have given.
I will work on all the points highlighted and hopefully make all the changes before Monday.
I appreciate your feedback. It shows great wisdom Sensei!