Product preview card

Community feedback

• 

  P

  Matt Pahuta•580

  @MattPahutaPosted 6 months ago

  • Good use of semantic HTML, however, the card's picture and content should not be separate sections. They are elements of the same product card, so better to make the card an individual section (within your main tag) or simply a div and use child divs to create your column/row layout.
  • Similarly, there's no need to set a width on your main tag. The card component should be a child of the main tag. Set a max-width and use a media query on the card component to achieve the desired size of the component.
  • Grace Snow wrote an excellent article on how she would approach writing this project's HTML. I highly recommend checking it out.
  • Also, great use of the picture tag to handle the card image but you don't (and shouldn't) need to set a height. The object-fit property is worth using here as well to prevent image distortion.
  • Related to the image, instead of setting border-radius properties directly, set it on the card (parent) along with overflow: hidden. You can then remove border-radius properties on child elements.
  • You're styling on ID selectors in a few places. This should be avoided as ID selectors can result in very high specificities and create styling conflicts that are difficult to troubleshoot. Use classes or element selectors instead.
  • Don't set a max-width or width on the body element. If you need a way to contain the card component, use a wrapper div. For this project, you could use the main element or, better yet, avoid one altogether. Using flexbox or grid display properties on your body element would work to keep the card component aligned and centered.
  • Your CSS is nicely concise but you ought to use a modern CSS reset for this project (and any in the future). Josh Comeau and Andy Bell both have excellent resets you can incorporate into your CSS file (or use as a separate file).
  • Media queries should be set in rem/em, not px. Here's a great resource
  • You're missing hover and focus states on the button.
  • Overall, very nice work here. With some relatively minor revisions to your code, you'll have a much closer match to the design comp. Cheers!

  Marked as helpful

  0
• 

  Rebeka•170

  @BekiaDPosted 8 months ago

  Looks neat! I will look into srcset too :)

  0