Skip to content
Submitted 8 months ago

Product Preview Card

Sean•210
@UFXtrendscalper
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Learned about using the tag for switching images based on media size.

What challenges did you encounter, and how did you overcome them?

I had some issues with changing the size of the image within the button. I'm using display flex and had to use flex-basis to adjust the img size.

What specific areas of your project would you like help with?

I was using chrome for this project and when I went to view the project in firefox it looks not the same. If anyone has any knowledge or tips about learning cross-browser techniques, it would be greatly appreciated.

Community feedback

  • Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    Hi @UFXtrendscalper ,

    You can try using following:- https://necolas.github.io/normalize.css/

    Go to this website, click download and you will see the stylesheet, save this stylesheet.

    Now, whenever you build a project, prefer adding this stylesheet in your markup, then add your custom stylesheets.

    Normalize.css makes browsers render all elements more consistently and in line with modern standards.

    Hope this helps !

    Marked as helpful
    1
    Sean•210
    @UFXtrendscalperPosted 8 months ago

    @Harsh-Kumar-Dwivedi Thank you I will hop over and give a read.

    0
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted 8 months ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have a suggestion regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • This solution contains some minor semantic issues which may cause lack accessibility
    • The <p>PERFUME</p>, must want to be changed to normal case like Perfume
    • Providing uppercase letter to them is not a good practice and the screen reader will read it as letter by letter like P, E, R etc.
    • Don't worry we can use text-transform: uppercase to transform the letter and letter-spacing: 1rem for the text Perfume
    • And another thing that the old price is not being properly announced, you have used h3 element for that (<h3>$169.99</h3>).
    • Actually there's a native html element which comes handy in these situations. it is del element
    • So you can use like this <del>$169.99</del>
    • These are the tips which improves the accessibility in real world situations.
    • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    1
    Sean•210
    @UFXtrendscalperPosted 8 months ago

    @0xabdulkhalid That's awesome, Thank you I appreciate that. I just played around with your feedback.

    1
  • madjacky•80
    @madjackyPosted 8 months ago

    good work

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord