Product Preview Card

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • it is best practice to have separate files for your HTML and CSS as it will make your code easier to maintain and organize.

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • The name of the perfume , “Gabrielle Essence Eau De Parfum”, is the most important content in your card so it should be wrapped in a heading Element.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0

  ---

  

  Ivan•30

  @shiyifanPosted almost 2 years ago

  @vcarames Thank you for your help! Especially the <picture> solved my problem absolutely and broaden my css knowledges. I've updated the code and I should learn more things with repect to the semantic html labels~

  0

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  @shiyifan

  I am glad that I was able to help out!

  Keep it up!

  0
• Account deleted

  Hi @shiyifan! In regards to your question, you should use a <picture> tag in these cases where you need to load a different image depending on the device's vw.

  Relevant docs: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture

  1
• 

  cmb347827•750

  @cmb347827Posted almost 2 years ago

  I haven't looked at your code, but it sounds like you may need to look into css flex?

  0