Bernardo Poggioni• 5,140
@R3ygoski
Posted
Hello Luke, first of all, congratulations, your solution looks good and is almost similar to the proposed design.
Regarding your question, I'll start with redundancy; apparently, no, it seems quite clean and without redundancies.
As for what could be improved, there are some areas I'd like to highlight:
- Instead of using image swapping the way you did, you could use a <picture> element; here's a link about it: W3School - Picture
- Using more semantic tags to enhance accessibility. Some examples of areas that could use semantic tags:
- <div class="card-wrapper"> could be <main>, as it's the main content.
- <div class="card"> could be <article>, as it's self-explanatory.
- <div class="card-image"> could be <figure>, as it contains only one image and it's also the main image of the page.
Now, a tip regarding using rem; I strongly recommend using it for your fonts. I noticed that some did, but others didn't. The important reason for using rem for fonts is that it allows them to adapt to the user's font settings.
Once again, congratulations on the project, it looks very good. Keep practicing and improving. If you have any questions, please ask below, and I'll try to help.
Marked as helpful
1
