Product Preview Card

Community feedback

• 

  jerry•300

  @realsalePosted over 2 years ago

  Yo! @shaswatsingh19,

  Congrats submitting your solution to this design, it's a great start

  You're solution is actually responsive, and you're following desktop first approach, and I've notice you're aligning your component with the old approach using margin auto on left and right, there's nothing wrong in that especially in simple layouts, however its hard to create complex layouts with that approach.

  In terms of responsive web design I recommend learning the following:

  • @media query as it allows you to add breakpoints which you can use to target specific screens, devices, dimensions, orientations etc. Using media queries
  • mobile first approach when doing responsive web design, It is recommended to design the mobile first before moving on the larger devices(This will make the page display faster on smaller devices) How to write mobile first
  • flex and/or grid as these are the modern layout approach Beginners guide to flexbox | Beginners guide to grid

  Marked as helpful

  0

  ---

  

  Shaswat Singh•190

  @shaswatsingh19Posted over 2 years ago

  @realsale thanks for the replay I have used flex and media query but still back of my mind there is someone who know I didn't did well.

  0

  

  jerry•300

  @realsalePosted over 2 years ago

  @shaswatsingh19 Yes you do used flex in the component itself, but not in the components container,

  It's natural at first to do mistake or to did something the wrong way, it's all part of the process, what's matter is "you do learn every single time you did this, you did that, learning how it fails and such..."

  You don't have to be hard at yourself, just enjoy things as you learn and give yourself a little reward if you've done or complete something.

  0

  

  Shaswat Singh•190

  @shaswatsingh19Posted over 2 years ago

  @realsale sure Thanks

  0