Design comparison
Community feedback
- @tobaojoPosted 11 days ago
Looks really good, I think you could benefit from using
gap
or somepadding
for your text content. Also It's not responsive. Perhaps try looking at the mobile design provided to get some ideas on how you can make this component responsive.Some other pointers:
The path to the
Montserrat
font file has a typo:tff
should bettf
.font-family
should be used instead offont-style
for applying custom fonts.The card width is currently set to
35%
of the viewport. While this works on large screens, it may look overly wide on some smaller screens. Adding a media query can make it more responsiveYour image styling is mostly good, but adding
object-fit:
cover instead of contain will prevent empty spaces within the image box if the aspect ratio differsEnsure text inside the button isn’t wrapped in a
<p>
, as it’s semantically incorrect and may affect accessibility.The
min-width
andmax-width
properties of.card
may benefit from further tweaking, especially if targeting devices smaller than340px
.Marked as helpful0@eman2point0Posted 10 days ago@tobaojo I'm still getting used to working with media queries but thanks for the advice!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord