Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

product preview card

@yahyashareef48

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I took about 8 hours, but still it's not good. I don't know why. please Tell me where I went wrong, and how can i improve.

important note : please check out my site on web frontend mentor is having some problem

Community feedback

@amalkarim

Posted

Hi Naser,

When in mobile view (when the browser width is less than around 600px), your site is zoomed out (the text size is smaller than it should be). Add this style to solve it:

@media only screen and (max-width: 995px) {
  .container {
    ....
    max-width: 100%;
  }
}
  • By adding max-width: 100%; to the .container inside the media query, it will make sure .container doesn't have wider area than the body.
  • Add padding: 20px; to the body would be nice too.
  • I think it's better to give padding to <div class="product-description col-lg-6 .col-md-12">, so that we don't need to give margin to every elements inside it.
  • To create better positioning for the discounted price and real price, I would recommend placing them inside a container that has display:flex;.

Hope this helps. Happy coding

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord