Design comparison
Solution retrospective
Hi! Thanks for taking a look at my work.
Is the way my HTML structured considered best practice with the divs and the class names?
And in my CSS, I was unsure of the naming best practices as well.
Thanks, Jesse
Community feedback
- @HassiaiPosted almost 2 years ago
Replace <div class="section"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
To center .main on the page using flexbox, replace the height in .section with min-height: 100vh. There is no need to give .section a height value and padding value in the media query. For a responsive, in the media query give .main a max-width value.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful1 - @fibonacci001Posted almost 2 years ago
you can choose to use Use descriptive class names, Class names should describe what the element does, not how it looks. For example, use .btn for a button, rather than .red-btn for a red button. Minimize the use of generic class names: Avoid using generic class names like .container or .row, which may not accurately describe the purpose of the element. although HTML structure are largely subjective and can vary based on personal preferences and specific project requirements. hope this was helpful Jesse
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord