Product Preview Card

Community feedback

• 

  Taner•190

  @tanererenPosted almost 2 years ago

  Hey! Well done on completing the project

  I noticed that you forgot to upload the images onto github, that along with editing the links may solve the issue - usually the image src will be written as: images/image-product-desktop.jpg - with images being the folder name

  Please check out this really useful free course by Kevin Powell - Conquering Responsive Layouts - this will help with creating mobile friendly layouts

  Please let me know how you get on or if you need anymore help!

  Marked as helpful

  1

  ---

  

  Simon•20

  @simonmatt89Posted almost 2 years ago

  @tanereren Thank you very much for the feedback!

  1

  

  Taner•190

  @tanererenPosted almost 2 years ago

  @simonmatt89

  No worries, I just had another look at your project and you can use the url link below to get the image to show

  /images with the / meaning: path before where the CSS file lives

  .left {
      width: 50%;
      background-image: url(/images/image-product-desktop.jpg);
      background-repeat: none;
      background-size: cover;
      background-position: center;
  

  Marked as helpful

  1

  

  Simon•20

  @simonmatt89Posted almost 2 years ago

  @tanereren Thanks again!, I tried to fix this issuen but I missed of the first / . Thanks for pointing that out. All of my images are now working.

  1
• 

  Jerome Dela Cruz•210

  @noonecaresman023Posted almost 2 years ago

  Hi! Regarding your problem that your images is not showing up, include your image/s when uploading them to github and reference your image path accordingly since right now your images are stored within your documents folder but github wouldn't know where that is as it is not included in the uploaded file. Also, I advise you to take a look at semantic html element for better readability, as to avoid using divs. I also noticed that you used h tags incorrectly, so, generally, if you are using h tags, use them in order, I'd avoid in using h4 without using h3 first (Note: use h1 tags once). If you are having difficulty creating a mobile version of this site, might I suggest you create mobile design first then go to desktop version. Let me know if you have more questions! Happy coding!

  Marked as helpful

  1

  ---

  

  Simon•20

  @simonmatt89Posted almost 2 years ago

  @noonecaresman023 Thank you, appreciate the feedback!

  1