@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
-
Apply the recommendations that the other member mentioned, before moving on to the next challenge, so you do not make the same mistakes.
-
Increase 📈 the
width
of the component to better match the FEM example. -
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
The Header Element is not needed for this challenge and is being used incorrectly.
-
The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
-
Wrap the prices in a container and use
display: flex
along withalign-items: center
to have them perfectly aligned like the FEM example. -
Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃