product-preview-card

Community feedback

• 

  Boris•2,870

  @mkborisPosted 2 months ago

  Nice work @seadadevo, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around the .container and a footer for the attribution.
  • To handle responsive images effectively you can use the picture element. This allows you to specify different images for various screen sizes and resolutions. Using CSS to hide and show images to display differently on various screen sizes is not part of the best practices.
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
  • Media queries should be defined in rem not px
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.

  Marked as helpful

  1