@eros77sc
Posted
Hi!
Great job on creating another page! Here are a few small things I noticed about your code:
- Good idea using
background-image
; another possibility could have been to use the<picture>
element, allowing the browser to choose the ideal image depending on the size, which would help reduce the amount of code needed for properties likevisibility
andbackground
. - One tip you might want to apply is about the visual organization of your code: try to maintain consistent indentation for selectors, properties, and values. This makes it easier to read and locate information. The same applies to the spacing between each CSS rule.
- The button could be created with a
<button>
element instead of<div class="button">
, as it not only makes the HTML more semantic but also more accessible. In the end, it allows for the same CSS styling. - You mentioned that scaling for desktop was a challenge, but you did a great job! And the mobile version looks really good too.
Happy coding, take care!
Marked as helpful
@manuel360
Posted
@eros77sc thanx very much for the advice and contributions.