@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π:
-
Use the
<footer>
tag to wrap the footer of the page instead of the<div class="attribution">
. The<footer>
element contains information about the author of the page, the copyright, and other legal information. -
The
alt
attribute is used to provide a text description of the image which is useful for screen reader users, assistive technology users, and search engine optimization. Add thealt
attribute to the<img>
tag of the product.
CSS π¨:
-
The simplest way to set the height of the body element is with
min-height: 100vh
, setting the height to 100% on both the body and html elements can cause your component to be cut off on small screens, such as a mobile phone in landscape mode.Here is an image of how it would look on a mobile device (taking into account the scroll): screencapture-melisguclu-github-io-product-preview-card-component-main
-
Use
padding: 1rem;
instead ofmargin: 1rem;
in the body element to remove the scrollbar on desktop devices
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful