Product preview card

Community feedback

• 

  ezecoder•870

  @3eze3Posted over 1 year ago

  Hello Ana Milanezi, good result for this challenge.

  I have some suggestions that you can keep in mind for future projects. Html:

  • Regarding the tags you could use main as a container instead of the div tag, to have better semantics.

  • It would be more appropriate to have a class structure, since you can have specificity problems if you use id,

  • The level of the titles must have a concordance, for example first h1, h2, not h6, h1 because we would not be giving a good acecibility, it is recommended that the first title is always h1.

  You could choose to use a methodology such as BEM, which is friendly and easy to learn and quick to apply.

  If you are interested, here is a link to BEM: https://en.bem.info/methodology/html/

  Css:

  • You could use some reset in a separate file for the specific elements you decided to use for this project.
  • Have declared variables like colors for the fonts or some properties that repeat, so you have more control over the code.

  I hope these recommendations will be useful for you, success.

  Happy coding❤

  Marked as helpful

  1