@amalkarim
Posted
Hi Mohammed, congratulations for your first submission!
Here are some suggestions.
- First, we need to fix the images url both for product image and button image, because the images are not in folder
images
but in root folder. - I personally prefer the product image as the
<img></img>
element instead of background-image, because those images are important. - Give the
body
elementmin-height: 100vh;
instead ofheight: 100vh;
to make sure that when the browser screen is shorter than the content, all parts of the content are visible and the page is scrollable. And also add somepadding
to thebody
in order to give a nice breathing room for the content.
Please note that those are my personal view. Feel free to disagree.
Hope this helps
@momoel00
Posted
@amalkarim , i will take all your remarks on the consideration , thank you a lot ms. amal , i appreciate it,