Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card

@momoel00

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


if you have any feedback please let me know will be help me a lot , thank you.

Community feedback

@amalkarim

Posted

Hi Mohammed, congratulations for your first submission!

Here are some suggestions.

  • First, we need to fix the images url both for product image and button image, because the images are not in folder images but in root folder.
  • I personally prefer the product image as the <img></img> element instead of background-image, because those images are important.
  • Give the body element min-height: 100vh; instead of height: 100vh; to make sure that when the browser screen is shorter than the content, all parts of the content are visible and the page is scrollable. And also add some padding to the body in order to give a nice breathing room for the content.

Please note that those are my personal view. Feel free to disagree.

Hope this helps

0

@momoel00

Posted

@amalkarim , i will take all your remarks on the consideration , thank you a lot ms. amal , i appreciate it,

0
M.Panda 200

@Sebastienpanda

Posted

Hello, first of all congratulations for your first project! What I can advise you is to do this for your fonts:

h1,h2,h3,h4,h5,h6{
font-family: "Noto Sans"
}
*,html,body{
font-family: "Roboto"
}

For the rest I advise you to use the tag main and section for semantics that would be more practical! Otherwise great project !

0

@momoel00

Posted

@SebastienWeb thank you for your feedback , i appreciate it,

1
M.Panda 200

@Sebastienpanda

Posted

@momoel00 With pleasure

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord