Product-preview card

Community feedback

• 

  sediqa•150

  @Hasani-SediqaPosted 18 days ago

  The style looks good, i think you can change the height of the card.

  Marked as helpful

  0
• 

  Hrid Chakraborty•70

  @hrid-chakrabortyPosted 18 days ago

  Awesome work!! The card looks great!!

  I have a few observations/suggestions which I hope will help you:

  1. For the body style, the min-width has been set to 100vh instead of 100vw (maybe a typo). Setting this to 100vw makes it much more responsive.

  The affected code block:

  body {
      min-width: 100vh;  // Change this to 100vw
      display: flex;
      align-items: center;
      justify-content: center;
      background-color: var(--Cream);
  }
  

     

  2. It is recommended to use semantic html (eg. <article>, <header> etc.) over plain <div> and <span> as it offers more meaning and has several benefits:

  • It helps search engines index the content properly.
  • It also enables screen readers and other assistive technologies to communicate elements properly to the user.

  0