Product preview card

Community feedback

• 

  Adriano•38,390

  @AdrianoEscarabotePosted almost 2 years ago

  Hi Nicolas, how are you? I really liked the result of your project, but I have some tips that I think you will enjoy:

  I noticed that you made your entire code using divs! this is not a good practice since div has no meaning, to improve the structure of your code we can use semantic elements that have meanings, not only for us who are developers, but also for screen readers, that is, a person who uses tools to browse the web, can better understand the content if our code is well written with semantic tags and some other features to improve accessibility!

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Nicolas•50

  @NA1DES17Posted almost 2 years ago

  @AdrianoEscarabote Thanks for the comment, they had already done it to me in another previous project... I'll try to improve them for the next one.

  1
• 

  Muhammad Adam•210

  @Muhammad-adam778Posted almost 2 years ago

  Good job, Nicolas it almost match the design

  • About accessibility:
  • In the first and third warning: Semantic HTML Elements would solve the problem, you need to use elements like <main>, article, figure, and button.
  • If you want to know about Semantic Elements check this link Semantic HTML Elements.
  • In the second one : You need to add <h1> Element to your page.
  • I hope you find this helpful.

  Marked as helpful

  0

  ---

  

  Nicolas•50

  @NA1DES17Posted almost 2 years ago

  @Muhammad-adam778 Thank you very much, I will keep it in mind for the next project

  1