Product preview

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • The article element is not meant to use here, because it cannot define landmark of a webpage

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <article class="container"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Joel Leon•100

  @iJoel23Posted over 1 year ago

  Hey there, @0xAbdulKhalid !! This information is very helpful, I'll fix it right away, thanks!

  0
• 

  Amar Kosare•170

  @amar215Posted over 1 year ago

  Your Code is very well written. (for my eyes, at least 😂).

  Just learned that we can use <picture> tag in HTML to switch images. in <picture> tag we give 3 elements. 2 are sources to images giving them max-width and min-width for responsiveness. and 3rd element is <img> to view the image.

  I almost forgot that we can use flex to center the 'Price' section and 'Button' section which is that 'cart' SVG and 'add to cart' text.

  Above all, the solution was great!

  Marked as helpful

  0

  ---

  

  Joel Leon•100

  @iJoel23Posted over 1 year ago

  Thanks a lot @amar215 !! I didn't realize the 3 elements we need to add inside of the picture tag, but I'll keep that in mind 🤓

  1