product preview

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The purpose of the Main Element is to identify the main content of your page. It is not the container of you component. After the main element, you want add a container to wrap you separate components in.

  • For this challenge you want to use the Picture Element not the Background Image Property. The Background Image Property is mainly used on decorative images

  Picture Element will allow your to switch between images in different breakpoints and makes your site load faster by saving bandwidth.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • It is best practice to use, Classes for your naming convention as classes are reusable, making them ideal for CSS styling. IDs on the other hand, are not reusable and are mainly used for JavaScript.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  0
• 

  TOCHUKWU UCHE•280

  @Toch007Posted about 2 years ago

  This is one of the best I have seen so far. I love the transition to the mobile view, really smooth. The only issue is that since you are using an Article Element, you might have to include h2 - h6 elements, or you could just change it and use the Div element. I believe the Article Element is mainly for writing articles. I hope this helps. Keep up the good work.

  0