@correlucas
Posted
👾Hello @jamesaking02, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
1.The image is not responsive yet, a quick way to make any image responsive and respecting the container size is to add display: block
and max-width: 100%
to the <img>
selector. To improve the responsiveness even more adding the auto-crop property you can add object-fit: cover
to make the image crop inside the container its inside.
img {
display: block;
object-fit: cover;
max-width: 100%;
}
2.Improve the card's overall look by adding the rounded borders to the component and also the image using border-radius: 15px
- Add rounded borders to the left side of the image with
border-radius: 15px 0px 0px 15px;
- Then do the same thing for the component but in the opposite borders
border-radius: 0px 15px 15px 0px;
3.Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture>
tag instead of importing this as an <img>
or using a div with background-image
. Use it to place the images and make the change between mobile and desktop, instead of using a div
or img
and set the change in the css with display: none
with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture>
tag and use the html to code to set when the images should change setting the device max-width
depending of the device desktop + mobile.
Check the link for the official documentation for <picture>
in W3 SCHOOLS:
https://www.w3schools.com/tags/tag_picture.asp
See the example below:
<picture>
<source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
<img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>
👨💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1
✌️ I hope this helps you and happy coding!
@jamesaking02
Posted
@correlucas Thank you for the feedback!