Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

product page perfume

@davidosi93

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

to adjust the mobile img for every screen

What challenges did you encounter, and how did you overcome them?

to adjust the mobile img for every screen

What specific areas of your project would you like help with?

a better solution for the img size for every screen size

Community feedback

P
Steven Stroud 4,100

@Stroudy

Posted

  • A <header> element typically contains one or more heading elements (<h1> - <h6>) logo or icon authorship information, Consider giving your PERFUME a (<h1> - <h6>),

  • PERFUME Should all be lower case in HTML and styled in CSS with this text-transform: uppercase;,

  • There are short hands for padding for example:

@media (max-width: 700px) {
  body {
    padding: 40px 30px 40px 30px; 
    padding: 40px 30px; ✅
    This sets 40px for the top and bottom, and 30px for the left and right.
  }
  • Having a clear and descriptive alt text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines use alt text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images,

  • Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning.

  • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

Marked as helpful

1
P

@adamwhitehouse95

Posted

Hey. Great looking site. Would say your padding/margins could be modified in mobile size to adhere to the design spec but overall good job.

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord