@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
CSS ๐จ:
- The error you are talking about is that in Chrome the image is too large and pushes all the text? If that's the problem, you should use
width: 50%;
on the image and in<div class="detail-container">
and it should be solved, usingwidth: 100%
makes the image take up the entire width.
HTML ๐ท๏ธ:
- Use the
<footer>
tag to wrap the footer of the page instead of the<div class="attribution">
. The<footer>
element contains information about the author of the page, the copyright, and other legal information.
-
The
<h1>
is the most important heading on the page, In this challenge the perfumer's name can be considered like the title of the page, so it should be the<h1>
-
Avoid using uppercase text in your HTML because screen readers will read it letter by letter. You can use the
text-transform
property to transform the text to uppercase in CSS.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful