Product List with Cart (VueJS, Pinia, TypeScript, A11Y)

Community feedback

• 

  P

  Christopher Adolphe•600

  @christopher-adolphePosted 9 days ago

  Hi @tinuola 👋

  You did a great job on this challenge. 👍 I had a quick look the code base and here's small feedback:

  • You could simplify the interface of the ProductCard.vue component by declaring only a product props instead of each field of a product as follows:

  defineProps({
    product: Product;
  });
  

  This will enhance readability.

  <ProductCard
    v-for="product in products"
    :key="product.name"
    :class="{ selected: product.selected }"
    :product="product"
  />
  

  I hope this helps.

  Keep it up.

  Marked as helpful

  1

  ---

  

  HelloTechTinu•670

  @tinuolaPosted 9 days ago

  @christopher-adolphe Thanks for the review/feedback!

  0

  

  P

  Christopher Adolphe•600

  @christopher-adolphePosted 8 days ago

  @tinuola you are welcome.

  I'm happy to help 🙂

  0