Design comparison
Solution retrospective
I'm most proud of this being my first project using tailwind styling. I learned a lot and it'll be even easier to use Tailwind next challenge!
What challenges did you encounter, and how did you overcome them?I found a little issue with the increment and decrement pill. Each time I would increment or decrease the quantity of an item, the pill would resize slightly. My hunch was that this was happening because the pill would resize to accommodate the changing quantity of text. After some research, I learned how to prevent that. By adding a fixed, ex. 0.75rem, to the quantity text the pill no longer resizes when incrementing or decrementing the quantity.
What specific areas of your project would you like help with?Any feedback is welcome!
Community feedback
- @WlfernandoPosted about 1 month ago
hi! I saw the DOM and I recommend to use less divs and use more semantic HTML, you could use: <ul>, <li>, <section>, <aside>, <article>, etc. Its a theme of accessibility. Or use the attribute role and aria-* on the divs.
Also, relate the code to the repository for the project, please.
1@ianwilk20Posted about 1 month ago@Wlfernando Thank you so much for this feedback! I appreciate you taking the time to share how I can make my challenge adhere to the principles of semantic HTML. I've gone ahead and revisited the coding challenge and tried my best to incorporate the semantic elements you spoke of.
Thanks again!
p.s. I've fixed the link to the repo too
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord