Product List with Cart

Community feedback

• 

  Andrey•2,570

  @dar-juPosted 30 days ago

  Hi Yeiser Jimenéz!

  Great job! You did a great job with the animation, I like it!

  There are a few things that could be improved:

  • look at the screen resolution 1025-1530px, the buttons don't look very good
  • there is no scrolling in the Confirmed Order popup, if you add a lot of products, the close button goes down off the screen and you can't click it to close
  • when you add a product to the cart, a vertical scroll bar appears in the cart for a moment. It's probably better to increase the block size first, then add the product. When you delete it, it's the opposite.
  • there's only one thing about the animation - when you place an order, the elements in the Confirmed Order are added too slowly, as if the page is lagging
  • you have a missing heading hierarchy, if Desserts is H1, then the product names should be H2
  • hover effects are not added to all buttons
  • keyboard accessibility is well-designed, but ARIA accessibility could be improved. For example, from an accessibility point of view, it is unclear what the +/-/x buttons do
  • you need to check the code in the validator, there is an errors in html: Element button and div are not allowed as child of element picture
  • the <section> tag can be used if the section has a H2-H6 header, otherwise better use another tag
  • there are explicit lists on the page - a list of products, a list of orders. ul/li is semantically suitable for them.

  Otherwise, great, good luck with your development!

  Marked as helpful

  1