Design comparison
Solution retrospective
A step up in terms of complexity and building things with Angular. I feel like this went OK, but more practice is needed.
What challenges did you encounter, and how did you overcome them?Typescript continues to be a challenge, but I can see its benefits. I am also reaching into the DOM and have concerns about mutating state that I need to better understand.
What specific areas of your project would you like help with?I've a couple of questions I'd love feedback on - mostly based on my experience with React:
Am I mutating state and does this matter? In the button component I am increasing/decreasing the quantity within the component rather than destroying and updating the state in DesertsService. Everything seems to work OK, but I'm not sure if this is bad practice?
Reaching into the DOM... I'm reaching into the DOM to remove items from the Cart component. I feel like this is wrong. From working with React I feel like I should be handing this over to Angular to take care of rather than using querySelector.
I am also using the native HTML dialog element and methods for the modal. Again this feels wrong, and being able to dismiss the modal with the escape key knocks state out of sync. I used @viewChild to access the dialog, but honestly, I just pasted this in with little understanding.
Community feedback
- @JudenetworkPosted about 2 months ago
Great work project. Can you let users to sign up and sign in for the website so that during shipping there won't be confusion of goods.
Thanks.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord